Reduce the maintenance burden of needing to update the documentation
when the interface changes.
This is needed for T363358, which refactors some classes that build
Special:Contributions.
Bug: T364569
Change-Id: Ia14784908790dc2cfd1b65b738730f759c780642
In I05e1c6dc322939619855a690a55d07adcb6b55ae two
enum config options GEHelpPanelAskMentor and
GEHelpPanelHelpDeskPostOnTop. However GE code
still expects these options to be booleans.
Introduce a wrapper config reader that relies
on CommunityConfiguration WikiPage reader but maps
new values to old values. This is in order to keep
the config code intact for eventual roll backs of
the CommunityConfiguration extension/migration.
Bug: T364053
Change-Id: I279040fef9ebcb42d333096d6675b3051e4101ed
Why:
fixLinkRecommendationData currently refuses to run
in production when --db-table is passed as an argument.
This is because the search index is delayed, and it
takes hours (if not days) to recognize update commands
coming from GrowthExperiments.
Unfortunately, when recovering from broken search index
scenario (T362367), the only solution for dangling DB
records is to drop them all, and deal with possible
incorrect removals later (by re-running the script
with --search-index).
What:
Add --force, which bypasses the "unsafe for production"
check. I documented it as "use with care", as during normal
operation, there is no reason to ever need to force it,
and understanding why the check is there is critical
to avoid breakages.
Patch also updates docstrings, as batching is in fact
implemented, and replication lag is checked in
commitTransaction(). The script indeed does not
handle search index update lag, so it has some risky
aspects, but assuming one is aware of the risks
(mainly increasing dangling search records, which
are more visible and problematic), it is executable
in production.
Bug: T364341
Change-Id: Ic8c563ce8fc36e67eeeb8a892e8f327f62a7b146
A spelling mistake was made for the property
GEHelpPanelHelpDeskPostOnTop. This is relevant
for migrating existing wiki configs to the new
config files structure without having to special
case this option.
Also rename the property associated messages.
Change-Id: Ibc61716ea5d7cecbe9dfdfa8ea41a75d84088512
`HelpPanel`, `GrowthHomepage`, `Mentorship`, and
`GrowthSuggestedEdits` configurations have been
updated to include links to their respective help
resources
Bug: T362203
Depends-On: Ic459a2d96c0963e891e8355cd4a10d09effab357
Change-Id: I5a3380ea0a5b70c0f71913f8bbc04a43edf79ec7
Use TYPE_INTEGER for pressumably int values and
keep TYPE_NUMBER for float values.
Bug: T363733
Depends-On: Ida3964c0293c67766607dcf437b8d26892418459
Change-Id: Ie5c9523758b660674af4a751275d6820f73f6876
The store was emitting QUEUE_LOADING/false events before the
task queue was actually updated. Consumers of the loading
event were getting an outdated task count.
In I75dcffaa35138165be22658f1844d98ea9af6384 we introduced
the same approach but it caused issues in the post edit dialog,
see T360469. The issues were caused by the store methods
hasPreviousTask and hasNextTask returning false while the
loading property has not yet been updated after fetching
tasks.
Emit the queue loading event after the queue
is updated and make store getters return the prev/next
computed value independently from the task queue loading
or not.
Note: the source problem remains in FiltersDialog.updateLoadingState
being only subscribed to TASK_QUEUE_LOADING and not task queue
changes. Consider refactoring it in follow-up in two different
handlers, one for loading state and another for new task counts.
Also consider using a state management solution eg Pinia.
Bug: T359992
Change-Id: Ib545b9f24ea6b84504a8ba4d2c4561737be9be0b
The field up_value is a varbinary and should be provided as string,
not all rdbms implicit converts int/strings
Change-Id: I3d016969559401ecc54bb27c192b66183d47345b
Prior to this patch,
Special:CommunityConfiguration/GrowthSuggestedEdits
had wrong labels in two places:
* `disabled` checkboxes were unlabeled in all places
except copyediting
* Add a link fields were unlabeled
In addition to this, two disabled labels were present,
both for the field and the control, which is inconsistent
with how we decided to represent booleans (cf. Mentorship).
This patch updates the labels for the form to meet expectations.
Bug: T360471
Change-Id: Ib92599555204966709c057a648f840838ebf543a
Immediately after merging the patch,
Special:CommunityConfiguration/GrowthSuggestedEdits will work,
but it will look very broken. This is because of T363477 and
T362098, which will make the form look (mostly) normally.
The form should now look like https://ctrlv.cz/1zNn, and
the config for the three structured tasks should work
as expected.
Bug: T360471
Depends-On: I6b6470ac05316f475660294740fecb4e35296229
Change-Id: I0a25dd94c5f88b2a887dc7879623dd9e3219e2c8
`GEHelpPanelLinks` is represented as associative arrays in
CC1.0, but in CC2.0, it is returned as a stdClass. Fix
that by adding a casing.
Also remedy PHP Warnings by renaming `label` to `text`,
which is expected in HelpPanel class. Otherwise,
the following notice would be displayed:
Warning: Undefined array key "text" in
/var/www/html/w/extensions/GrowthExperiments/includes/HelpPanel.php
on line 68.
Bug: T363459
Change-Id: I1507dcb6739cb22c5cf049d19b7e3bad8db2c0da
jenkins-bot