build: Resolve MediaWikiNoEmptyIfDefined suppression

Follow-Up: I7b9a7e20a5d177edfcba3c76a0d65228497e0d79
Change-Id: I3d468497b53fce67d643d0961fe3659e739def71

.phan/config.php

@@ -2,9 +2,6 @@
 
 $cfg = require __DIR__ . '/../vendor/mediawiki/mediawiki-phan-config/src/config.php';
 
-// To migrate later
-$cfg['suppress_issue_types'][] = 'MediaWikiNoEmptyIfDefined';
-
 $cfg['directory_list'] = array_merge(
 	$cfg['directory_list'],
 	[

src/WikiTexVC/MMLmappings/Util/MMLParsingUtil.php

@@ -204,7 +204,7 @@ class MMLParsingUtil {
 	 * @return string MML with added attributes
 	 */
 	public static function forgeIntentToTopElement( string $renderedMML, $intentContentAtr ) {
-		if ( empty( $intentContentAtr ) || empty( $renderedMML ) ) {
+		if ( !$intentContentAtr || !$renderedMML ) {
 			return $renderedMML;
 		}
 
@@ -251,7 +251,7 @@ class MMLParsingUtil {
 	}
 
 	public static function forgeIntentToSpecificElement( string $renderedMML, $intentContentAtr, string $elementTag ) {
-		if ( empty( $intentContentAtr ) || empty( $renderedMML ) || empty( $elementTag ) ) {
+		if ( !$intentContentAtr || !$renderedMML || !$elementTag ) {
 			return $renderedMML;
 		}
 		return self::addAttributesToMML( $elementTag, $intentContentAtr, $elementTag, true );